gitMirror/spdlog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix to a windows issue, where very high rotation rates sometimes fail if antivirus is running.

Browse Source
This commit is contained in:
gabime
2018-07-10 14:33:38 +03:00
parent cf6e9461af
commit b9180f8f5a
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/spdlog/sinks/rotating_file_sink.h
View File

@@ -95,7 +95,14 @@ private:
}
if (details::file_helper::file_exists(src) && details::os::rename(src, target) != 0)
{
throw spdlog_ex("rotating_file_sink: failed renaming " + filename_to_str(src) + " to " + filename_to_str(target), errno);
// if failed try again after small delay.
// this is a workaround to a windows issue, where on high rotation rates the rename fails sometimes (because of antivirus?).
details::os::sleep_for_millis(20);
details::os::remove(target);
if (details::os::rename(src, target) != 0)
{
throw spdlog_ex("rotating_file_sink: failed renaming " + filename_to_str(src) + " to " + filename_to_str(target), errno);
}
}
}
file_helper_.reopen(true);