gitMirror/spdlog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant size check before calling WriteFile

Browse Source
This commit is contained in:
Gabi Melman
2020-09-27 21:27:58 +03:00
committed by GitHub
parent dccb766095
commit 9799ecac6a
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/spdlog/sinks/wincolor_sink-inl.h
View File

@@ -146,11 +146,6 @@ void SPDLOG_INLINE wincolor_sink<ConsoleMutex>::write_to_file_(const memory_buf_
return; return;
} }
auto size = static_cast<DWORD>(formatted.size()); auto size = static_cast<DWORD>(formatted.size());
if (size == 0)
{
return;
}
DWORD bytes_written = 0; DWORD bytes_written = 0;
bool ok = ::WriteFile(out_handle_, formatted.data(), size, &bytes_written, nullptr) != 0; bool ok = ::WriteFile(out_handle_, formatted.data(), size, &bytes_written, nullptr) != 0;
if (!ok) if (!ok)