Address PR comments
This commit is contained in:
		@@ -214,13 +214,7 @@ void udp_example()
 | 
			
		||||
    spdlog::sinks::udp_sink_config cfg("127.0.0.1", 11091);
 | 
			
		||||
    auto my_logger = spdlog::udp_logger_mt("udplog", cfg);
 | 
			
		||||
    my_logger->set_level(spdlog::level::debug);
 | 
			
		||||
    for (int i = 0; i < 10; i++) {
 | 
			
		||||
        my_logger->info("hello world {}", i);
 | 
			
		||||
#ifdef _WIN32
 | 
			
		||||
        // sendto() on winsock will drop packets if sent too quickly
 | 
			
		||||
        std::this_thread::sleep_for(std::chrono::milliseconds(40));
 | 
			
		||||
#endif
 | 
			
		||||
    }
 | 
			
		||||
    my_logger->info("hello world");
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// A logger with multiple sinks (stdout and file) - each with a different format and log level.
 | 
			
		||||
 
 | 
			
		||||
@@ -3,6 +3,7 @@
 | 
			
		||||
 | 
			
		||||
#pragma once
 | 
			
		||||
 | 
			
		||||
#ifndef WIN32_LEAN_AND_MEAN
 | 
			
		||||
#define WIN32_LEAN_AND_MEAN
 | 
			
		||||
// tcp client helper
 | 
			
		||||
#include <spdlog/common.h>
 | 
			
		||||
@@ -125,4 +126,5 @@ public:
 | 
			
		||||
} // namespace details
 | 
			
		||||
} // namespace spdlog
 | 
			
		||||
 | 
			
		||||
#endif
 | 
			
		||||
#endif  // _WIN32
 | 
			
		||||
#endif  // WIN32_LEAN_AND_MEAN
 | 
			
		||||
@@ -17,12 +17,8 @@
 | 
			
		||||
#include <chrono>
 | 
			
		||||
#include <functional>
 | 
			
		||||
 | 
			
		||||
#pragma once
 | 
			
		||||
 | 
			
		||||
// Simple udp client sink
 | 
			
		||||
// Connects to remote address and send the formatted log.
 | 
			
		||||
// Will attempt to reconnect if connection drops.
 | 
			
		||||
// If more complicated behaviour is needed (i.e get responses), you can inherit it and override the sink_it_ method.
 | 
			
		||||
// Sends formatted log via udp
 | 
			
		||||
 | 
			
		||||
namespace spdlog {
 | 
			
		||||
namespace sinks {
 | 
			
		||||
@@ -42,7 +38,6 @@ template<typename Mutex>
 | 
			
		||||
class udp_sink : public spdlog::sinks::base_sink<Mutex>
 | 
			
		||||
{
 | 
			
		||||
public:
 | 
			
		||||
    // connect to tcp host/port or throw if failed
 | 
			
		||||
    // host can be hostname or ip address
 | 
			
		||||
 | 
			
		||||
    explicit udp_sink(udp_sink_config sink_config)
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user