gitMirror/spdlog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

removed nullptr checks and renamed member vars

Browse Source
This commit is contained in:
Muhammed Galib Uludag
2021-07-28 00:06:12 +03:00
committed by GitHub
parent 362fdc6ceb
commit 2ccba49b01
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
include/spdlog/sinks/qt_sinks.h
View File

@@ -26,7 +26,7 @@ class qtextedit_sink : public base_sink<Mutex> {
public: public:
qtextedit_sink(QTextEdit *textedit = nullptr) { qtextedit_sink(QTextEdit *textedit = nullptr) {
if (textedit != nullptr) { if (textedit != nullptr) {
qtextedit = textedit; qtextedit_ = textedit;
} else { } else {
throw spdlog_ex("Error opening QTextEdit"); throw spdlog_ex("Error opening QTextEdit");
} }
@@ -36,18 +36,16 @@ public:
protected: protected:
void sink_it_(const details::log_msg &msg) override { void sink_it_(const details::log_msg &msg) override {
if(qtextedit == nullptr)
return;
memory_buf_t formatted; memory_buf_t formatted;
base_sink<Mutex>::formatter_->format(msg, formatted); base_sink<Mutex>::formatter_->format(msg, formatted);
string_view_t str = string_view_t(formatted.data(), formatted.size()); string_view_t str = string_view_t(formatted.data(), formatted.size());
QMetaObject::invokeMethod(qtextedit,"append", Qt::AutoConnection, Q_ARG(QString, QString::fromUtf8(str.data(), static_cast<int>(str.size())).trimmed())); QMetaObject::invokeMethod(qtextedit_,"append", Qt::AutoConnection, Q_ARG(QString, QString::fromUtf8(str.data(), static_cast<int>(str.size())).trimmed()));
} }
void flush_() override {} void flush_() override {}
private: private:
QTextEdit* qtextedit = nullptr; QTextEdit* qtextedit_ = nullptr;
}; };
// //
@@ -58,7 +56,7 @@ class qplaintextedit_sink : public base_sink<Mutex> {
public: public:
qplaintextedit_sink(QPlainTextEdit *textedit = nullptr) { qplaintextedit_sink(QPlainTextEdit *textedit = nullptr) {
if (textedit != nullptr) { if (textedit != nullptr) {
qplaintextedit = textedit; qplaintextedit_ = textedit;
} else { } else {
throw spdlog_ex("Error opening QPlainTextEdit"); throw spdlog_ex("Error opening QPlainTextEdit");
} }
@@ -68,18 +66,16 @@ public:
protected: protected:
void sink_it_(const details::log_msg &msg) override { void sink_it_(const details::log_msg &msg) override {
if(qplaintextedit == nullptr)
return;
memory_buf_t formatted; memory_buf_t formatted;
base_sink<Mutex>::formatter_->format(msg, formatted); base_sink<Mutex>::formatter_->format(msg, formatted);
string_view_t str = string_view_t(formatted.data(), formatted.size()); string_view_t str = string_view_t(formatted.data(), formatted.size());
QMetaObject::invokeMethod(qplaintextedit, "appendPlainText", Qt::AutoConnection, Q_ARG(QString, QString::fromUtf8(str.data(), static_cast<int>(str.size())).trimmed())); QMetaObject::invokeMethod(qplaintextedit_, "appendPlainText", Qt::AutoConnection, Q_ARG(QString, QString::fromUtf8(str.data(), static_cast<int>(str.size())).trimmed()));
} }
void flush_() override {} void flush_() override {}
private: private:
QPlainTextEdit* qplaintextedit = nullptr; QPlainTextEdit* qplaintextedit_ = nullptr;
}; };
#include "spdlog/details/null_mutex.h" #include "spdlog/details/null_mutex.h"