Perfect forwarding for arguments

2020-11-02 00:37:03 +00:00
parent 01b350de96
commit 23572369fc
3 changed files with 40 additions and 40 deletions
--- a/include/spdlog/pattern_formatter.h
+++ b/include/spdlog/pattern_formatter.h
@@ -92,9 +92,9 @@ public:
    void format(const details::log_msg &msg, memory_buf_t &dest) override;

    template<typename T, typename... Args>
-    pattern_formatter &add_flag(char flag, const Args &...args)
+    pattern_formatter &add_flag(char flag, Args&&...args)
    {
-        custom_handlers_[flag] = details::make_unique<T>(args...);
+        custom_handlers_[flag] = details::make_unique<T>(std::forward<Args>(args)...);
        return *this;
    }
    void set_pattern(std::string pattern);