Commit Graph

1688 Commits

Author SHA1 Message Date
Hossein Ghahramanzadeh
2eadda6e00 Do constant time matching for exact match filters. 2022-01-31 19:22:37 +01:00
Derek Mauro
28e1da21d8 Finish some missed pieces of the TestCase to TestSuite Migration
PiperOrigin-RevId: 424864779
Change-Id: Iac5cafa3568f5fe41c85c52d28f7d61845f76868
2022-01-28 07:27:11 -08:00
Melroy van den Berg
f2d71f0be2 Let me give a change to try it again - updating to latest version 2022-01-25 22:45:24 +01:00
Abseil Team
f45d5865ed Make recreate_environments_when_repeating=false the default.
So that global test environments are by default set up and torn down once,
regardless of the value of the repeat flag.

The point of global environments is to be set up and torn down once, and shared
by all tests in the process. There is no obvious reason why multiple runs of the
same test should be treated distinctly from single runs of different tests.

Having this be false by default means that repeats using a global environment
run faster. It can still be set to true if it's desired that every repeat get a
fresh environment, but this seems less important given the nature of a global
environment. Every test I've seen using a global environment uses it to set up
some expensive external resource, not something that can/should be set up for
each test anew. (Again this is unsurprising, since the environment is a global.)

PiperOrigin-RevId: 424003937
Change-Id: I9e8a825cb8900960dd65b85fe5ffcc0a337e57f3
2022-01-24 23:46:52 -08:00
Copybara-Service
f64cf6b7b8 Merge pull request #3732 from joshiayush:i2174
PiperOrigin-RevId: 423906844
Change-Id: I1c34a3ce8a5c761ef9f1d7ce48bef8826742e97d
2022-01-24 14:08:19 -08:00
Copybara-Service
3d81736c97 Merge pull request #3615 from IYP-Programer-Yeah:fix-per-test-filter-processing
PiperOrigin-RevId: 423326942
Change-Id: I913f31960d7917b176c9f390424630708473837a
2022-01-21 08:18:49 -08:00
Abseil Team
2ddfdf819d Factor out AssertionResult into dedicated gtest-assertion-result header + implementation files to prevent cyclic includes between gtest.h and gtest_pred_impl.h
PiperOrigin-RevId: 422863083
Change-Id: I299018a860152216adc206780c32923c03bedb2a
2022-01-19 11:31:36 -08:00
Abseil Team
100f6fbf5f Consistently apply IWYU pragmas across googletest and googlemock headers
PiperOrigin-RevId: 422559250
Change-Id: I9f630f2186724950e5e9fbd7093d5264e8bf0a71
2022-01-18 08:11:11 -08:00
Copybara-Service
c9643a2e45 Merge pull request #3721 from joshiayush:i3719
PiperOrigin-RevId: 422405356
Change-Id: I8ea22485d9a25dce81a28d0c323a73b36d15e912
2022-01-17 12:59:48 -08:00
Ayush Joshi
ca3ffd90f2 FIX #2174 -- remove DEBUG_POSTFIX
while this is not synced with the pkg-config file, it only breaks things

Fix #2174

Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
2022-01-13 21:24:56 +05:30
Copybara-Service
aea0874c42 Merge pull request #3725 from bsilver8192:remove-another-disallow-assign
PiperOrigin-RevId: 421044680
Change-Id: If585089811f1b67eab6f339125c27174ee5bc290
2022-01-11 09:01:32 -08:00
Copybara-Service
1d9f7c5fb2 Merge pull request #3713 from PhilipMourdjis:cmake-qnx-link-regex
PiperOrigin-RevId: 420863433
Change-Id: Ie8c43caff6fb2493ecd47bed50de9db87221f46f
2022-01-10 14:56:50 -08:00
Hossein Ghahramanzadeh
29bc520e5b Fix a typo in comments. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
4fc151ae69 Use normal for loop instead of accumulate. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
aea981dd54 Improve code readablity. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
4adbc9c9b2 Apply requested changes to preserve old behavior. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
d03d23a6e5 Reimplement MatchesFilter with new interfaces. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
3fc1ab6632 Apply requested changes. 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
f20688737a Get rid of redundant filter matching code 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
f5b4efef5f Add comments describing the behavior of filters 2022-01-06 15:46:52 +01:00
Hossein Ghahramanzadeh
2377c8d32b Process filter string once instead of per test 2022-01-06 15:46:52 +01:00
Ayush Joshi
1b4cf35958 FIX #3719 -- Fix clang conversion warnings
We should perform an explicit type conversion to `unsigned char` before passing the
`const char` data to `IsValidXmlCharacter()` and `IsNormalizableWhitespace()` functions
in order to avoid compile time conversion warnings

Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
2022-01-01 19:28:21 +05:30
Derek Mauro
c58f562fa2 Makes the Python imports consistently use full paths from the repository root,
unifying the behavior between Bazel and CMake

This fixes one of the CI failures on Windows

PiperOrigin-RevId: 417872531
Change-Id: I156989323b7e6d4a4420f4f9691b078829db933d
2021-12-22 13:01:24 -08:00
Derek Mauro
71d4e2f742 Makes TestForDeathTest.CRTDebugDeath only run when _DEBUG is defined
PiperOrigin-RevId: 417678422
Change-Id: I8e42a906459b8fd5a7789a7ed728d12448046c44
2021-12-21 13:16:17 -08:00
Philip Mourdjis
4745746725 link to regex on qnx in cmake 2021-12-21 16:14:03 +00:00
Dino Radakovic
97a467571a Release tests for UnitTestOptions::MatchesFilter
PiperOrigin-RevId: 416567004
Change-Id: Ic407e0fcdf8ffd1c012a1b12df2837bdac1dccb4
2021-12-15 08:36:08 -08:00
Copybara-Service
054a986a85 Merge pull request #3694 from joshiayush:main
PiperOrigin-RevId: 415014511
Change-Id: If2e20eb9408a23b5574a2c87f651c2905f14fcac
2021-12-08 08:53:55 -08:00
Abseil Team
4c5650f688 Add NOLINT to address modernize-use-trailing-return-type in TEST_F uses
Example command:

```
clang_tidy '--config={Checks: "modernize-use-trailing-return-type"}' googletest-death-test-test.cc
```

Example error:

```
warning: use a trailing return type for this function [modernize-use-trailing-return-type]
TEST(NotADeathTest, Test) {
^
```
PiperOrigin-RevId: 414836261
Change-Id: I5f758423667559abfbf313190543666bc4ce0e6e
2021-12-07 15:09:13 -08:00
Ayush Joshi
3ea587050d Allow to specify a random seed independently of whether shuffling is requested
This commit fixes issue #3681

Signed-off-by: Ayush Joshi <ayush854032@gmail.com>
2021-12-04 21:18:18 +05:30
Abseil Team
bb9216085f Work around Android KitKat tzset bug
On KitKat, calling tzset with UTC+nn doesn't initialize all the
timezone state. If the previous timezone was something like
America/Chicago, then changing it to UTC+nn might have no effect.
Setting the timezone to an intermediate value like "UTC" avoids the
problem.

Works around https://github.com/android/ndk/issues/1604.

PiperOrigin-RevId: 413050236
Change-Id: I99b2d3330ae68f1d58cd2ca278d3eaae30bd1e83
2021-11-29 20:53:29 -08:00
Denis Samoilov
035a101b62 Suppress unused-value warning
When _DEBUG is not defined the _CrtSetDbgFlag turns into ((int)0),
which causes unused-value warning for clang.
2021-11-16 19:07:19 -08:00
dinord
7f2288476b Merge pull request #3657 from BioDataAnalysis:bda_add_winerr
PiperOrigin-RevId: 408896910
2021-11-10 17:21:09 -05:00
dmauro
6c8a386513 Googletest export
Explicitly used unsigned chars for testing for valid XML characters

PiperOrigin-RevId: 408692969
2021-11-10 17:21:00 -05:00
Mario Emmenlauer
e4ffd4d715 googletest/src/gtest-port.cc: Added GetLastError() on Windows for CreateThread() 2021-11-10 13:36:38 +01:00
Abseil Team
aa486f165e Googletest export
Add missing InitGoogleTest line in "Registering tests" example code

Copying the original code gives the following error message
"""
IMPORTANT NOTICE - DO NOT IGNORE:
This test program did NOT call testing::InitGoogleTest() before calling RUN_ALL_TESTS(). This is INVALID. Soon Google Test will start to enforce the valid usage. Please fix it ASAP, or IT WILL START TO FAIL.
"""

PiperOrigin-RevId: 408385714
2021-11-09 10:24:14 -05:00
Abseil Team
c3792825bf Googletest export
Add printer for std::type_info.

PiperOrigin-RevId: 408375407
2021-11-09 10:24:05 -05:00
Abseil Team
bf0701daa9 Googletest export
Address unused variable warning in gtest.h

Closes #3645

PiperOrigin-RevId: 407393922
2021-11-03 15:12:53 -04:00
CJ Johnson
51536300a1 Merge pull request #3638 from limitedAtonement:3637-disabled-output
PiperOrigin-RevId: 407356792
2021-11-03 13:46:13 -04:00
dmauro
cbf46d3f27 Googletest export
Guard #includes for threading related headers with GTEST_IS_THREADSAFE

Some platforms that don't support threading give errors for including
these headers

PiperOrigin-RevId: 406133623
2021-11-03 13:46:02 -04:00
dmauro
5a93ce1247 Googletest export
Remove the subprocess fallback code for older versions of Python

PiperOrigin-RevId: 405967578
2021-11-03 13:45:56 -04:00
dmauro
489ef888d9 Googletest export
Remove GoogleTest's SleepMilliseconds function.
It is only used in tests and a portable implementation is available.

PiperOrigin-RevId: 405437102
2021-11-03 13:45:40 -04:00
dmauro
f503588aee Googletest export
Replace the multiple implementations of Notification with a single
portable implementation.

The also removes the awkward loop with sleep in Notification and will
allow the removal of SleepMilliseconds.

PiperOrigin-RevId: 405399733
2021-11-03 13:45:35 -04:00
lmat
3c958ac47c Re #3637 Show Disabled Tests in testing output
Showing disabled tests is implemented by a new member function on the
TestEventListener interface (which is responsible for printing
testing output). The new function is called OnTestSkipped and it is
invoked when a disabled test is encountered.

The PrettyUnitTestResultPrinter has the canonical implementation of this
new function. The BriefUnitTestResultPrinter and the
EmptyTestEventListener get a nullary implementation. The
JsonUnitTestResultPrinter and XmlUnitTestResultPrinter
inherit that trivial implementation from the EmptyTestEventListener.
2021-11-01 16:17:25 -04:00
Deniz Bahadir
64f19a9fc3 CMake: Fix values of INTERFACE_INCLUDE_DIRECTORIES property
Replace semicolon by `$<SEMICOLON>` in generator-expressions of target
property `INTERFACE_INCLUDE_DIRECTORIES` of CMake targets `gtest`,
`gtest_main`, `gmock` and `gmock_main`.

Fixes: #3616

Signed-off-by: Deniz Bahadir <deniz@code.bahadir.email>
2021-10-19 15:14:44 +02:00
Abseil Team
16f637fbf4 Googletest export
Add printer for __{u,}int128_t.

PiperOrigin-RevId: 402417369
2021-10-13 12:28:20 -04:00
dinord
075810f7a2 Merge pull request #3581 from cclauss:codespell
PiperOrigin-RevId: 400792845
2021-10-05 10:59:42 -04:00
Abseil Team
3b49be074d Googletest export
googletest: Add printer for {std,absl}::nullopt.
PiperOrigin-RevId: 399928554
2021-09-30 19:07:32 -04:00
Christian Clauss
ee1be03b43 Fix remaining typos discovered by codespell 2021-09-24 08:09:32 +02:00
dinord
e4717df71a Merge pull request #3195 from Inujel:fix-3194
PiperOrigin-RevId: 398271948
2021-09-23 23:31:42 +00:00
dinord
09074c1571 Merge pull request #3573 from cclauss:patch-1
PiperOrigin-RevId: 397998384
2021-09-23 23:31:33 +00:00