Makes List a random-access data structure. This simplifies the implementation and makes it easier to implement test shuffling.

include/gtest/gtest.h

@@ -434,13 +434,14 @@ class TestResult {
   TimeInMillis elapsed_time() const { return elapsed_time_; }
 
   // Returns the i-th test part result among all the results. i can range
-  // from 0 to test_property_count() - 1. If i is not in that range, returns
-  // NULL.
-  const TestPartResult* GetTestPartResult(int i) const;
+  // from 0 to test_property_count() - 1. If i is not in that range, aborts
+  // the program.
+  const TestPartResult& GetTestPartResult(int i) const;
 
   // Returns the i-th test property. i can range from 0 to
-  // test_property_count() - 1. If i is not in that range, returns NULL.
-  const TestProperty* GetTestProperty(int i) const;
+  // test_property_count() - 1. If i is not in that range, aborts the
+  // program.
+  const TestProperty& GetTestProperty(int i) const;
 
  private:
   friend class DefaultGlobalTestPartResultReporter;

include/gtest/internal/gtest-internal.h

@@ -116,9 +116,7 @@ class ScopedTrace;                     // Implements scoped trace.
 class TestInfoImpl;                    // Opaque implementation of TestInfo
 class TestResult;                      // Result of a single Test.
 class UnitTestImpl;                    // Opaque implementation of UnitTest
-
 template <typename E> class List;      // A generic list.
-template <typename E> class ListNode;  // A node in a generic list.
 
 // How many times InitGoogleTest() has been called.
 extern int g_init_gtest_count;