Remove FloatingPoint::Max() in favor of std::numeric_limits::max()
In #4113 a user says Max clashes with a macro. Since it is only used in a test, use std::numeric_limits::max() instead. Note that in headers, the macro issue can be mitigated with parenthesis like this: `(std::numeric_limits<T>::max)()` PiperOrigin-RevId: 504284906 Change-Id: Ibf430caec1a6afdf6b303534fec6a4fd00a6373f
This commit is contained in:
		
				
					committed by
					
						
						Copybara-Service
					
				
			
			
				
	
			
			
			
						parent
						
							ec25eea8f8
						
					
				
				
					commit
					544c96ed5b
				
			@@ -307,9 +307,6 @@ class FloatingPoint {
 | 
			
		||||
  // Returns the floating-point number that represent positive infinity.
 | 
			
		||||
  static RawType Infinity() { return ReinterpretBits(kExponentBitMask); }
 | 
			
		||||
 | 
			
		||||
  // Returns the maximum representable finite floating-point number.
 | 
			
		||||
  static RawType Max();
 | 
			
		||||
 | 
			
		||||
  // Non-static methods
 | 
			
		||||
 | 
			
		||||
  // Returns the bits that represents this number.
 | 
			
		||||
@@ -390,17 +387,6 @@ class FloatingPoint {
 | 
			
		||||
  FloatingPointUnion u_;
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
// We cannot use std::numeric_limits<T>::max() as it clashes with the max()
 | 
			
		||||
// macro defined by <windows.h>.
 | 
			
		||||
template <>
 | 
			
		||||
inline float FloatingPoint<float>::Max() {
 | 
			
		||||
  return FLT_MAX;
 | 
			
		||||
}
 | 
			
		||||
template <>
 | 
			
		||||
inline double FloatingPoint<double>::Max() {
 | 
			
		||||
  return DBL_MAX;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// Typedefs the instances of the FloatingPoint template class that we
 | 
			
		||||
// care to use.
 | 
			
		||||
typedef FloatingPoint<float> Float;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user